[webkit-reviews] review granted: [Bug 204053] Stack allocate StyleResolver state : [Attachment 383232] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 9 19:47:26 PST 2019

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 204053: Stack allocate StyleResolver state

Attachment 383232: patch


--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 383232
  --> https://bugs.webkit.org/attachment.cgi?id=383232

View in context: https://bugs.webkit.org/attachment.cgi?id=383232&action=review

> Source/WebCore/css/StyleResolver.cpp:465
> +std::unique_ptr<RenderStyle> StyleResolver::defaultStyleForElement(const
Element* element)

It's sad that we need to pass in a raw pointer just to figure out if it is an
svg element.

More information about the webkit-reviews mailing list