[webkit-reviews] review granted: [Bug 204051] [WebAssembly] Improve bytecode dumping : [Attachment 383224] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 9 12:00:30 PST 2019


Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 204051: [WebAssembly] Improve bytecode dumping
https://bugs.webkit.org/show_bug.cgi?id=204051

Attachment 383224: Patch

https://bugs.webkit.org/attachment.cgi?id=383224&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 383224
  --> https://bugs.webkit.org/attachment.cgi?id=383224
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383224&action=review

r=me

> Source/JavaScriptCore/ChangeLog:17
> +	   <?>.wasm-function[26]: 6 instructions (0 16-bit instructions, 0
32-bit instructions); 14 bytes; 1 parameter(s); 18 local(s); 22 callee
register(s)

It’d be cool if we could dump the signature of the function here.


More information about the webkit-reviews mailing list