[webkit-reviews] review granted: [Bug 204037] Long-pressing support.apple.com categories shows a PNG instead of the web page preview, tapping loads image asset only instead of web page : [Attachment 383189] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 204037: Long-pressing support.apple.com categories shows a PNG instead of
the web page preview, tapping loads image asset only instead of web page
https://bugs.webkit.org/show_bug.cgi?id=204037

Attachment 383189: Patch

https://bugs.webkit.org/attachment.cgi?id=383189&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 383189
  --> https://bugs.webkit.org/attachment.cgi?id=383189
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383189&action=review

> Source/WebKit/ChangeLog:10
> +	   Sometime recently, Safari started using our ContextMenu API rather
than the old SPI. At that
> +	   point they accidentally began providing a PreviewViewController that
displayed the image

Maybe reword this.

> Source/WebKit/ChangeLog:15
> +	   This could be fixed in Safari, but I noticed that we actually tell
the delegate that the
> +	   type of the activated element is an image, which is why they treat
it as such. It's not
> +	   clear that because the image also has a link attached, a client
should defer to the link.

Are we not able to tell the client "link and image"?