[webkit-reviews] review denied: [Bug 204030] Make MediaStream/MediaStreamTrack page cache friendly : [Attachment 383192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 18:58:53 PST 2019

Chris Dumez <cdumez at apple.com> has denied  review:
Bug 204030: Make MediaStream/MediaStreamTrack page cache friendly

Attachment 383192: Patch


--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 383192
  --> https://bugs.webkit.org/attachment.cgi?id=383192

View in context: https://bugs.webkit.org/attachment.cgi?id=383192&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:578
> +    scriptExecutionContext()->postTask([this, pendingActivity =
makePendingActivity(*this)](auto&) {

We're not supposed to use postTask() anymore. Please use the HTML event loop by
calling queueTaskToDispatchEvent().

Also, because the HTML event loop is page-cache compliant, you can call
queueTaskToDispatchEvent() in suspend() and then you don't need a resume()
method or the m_isSuspendedForBackForwardCache flag.

More information about the webkit-reviews mailing list