[webkit-reviews] review denied: [Bug 204028] [WebAssembly] LLIntGenerator should not retain VirtualRegisters used for constants : [Attachment 383176] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 16:42:25 PST 2019


Saam Barati <sbarati at apple.com> has denied Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 204028: [WebAssembly] LLIntGenerator should not retain VirtualRegisters
used for constants
https://bugs.webkit.org/show_bug.cgi?id=204028

Attachment 383176: Patch

https://bugs.webkit.org/attachment.cgi?id=383176&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 383176
  --> https://bugs.webkit.org/attachment.cgi?id=383176
Patch

discussed offline with Tadeu. This isn't sound, since a local can be written to
with a non constant. It's not a static property of a local


More information about the webkit-reviews mailing list