[webkit-reviews] review granted: [Bug 203101] PaymentRequest / PaymentResponse should not prevent entering the back/forward cache : [Attachment 383162] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 203101: PaymentRequest / PaymentResponse should not prevent entering the
back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203101

Attachment 383162: Patch

https://bugs.webkit.org/attachment.cgi?id=383162&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 383162
  --> https://bugs.webkit.org/attachment.cgi?id=383162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383162&action=review

> Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp:177
> +void DeferredPromise::queueTaskKeepingSelfAlive(TaskSource source,
Function<void()>&& task)

This is no longer needed now that my patch landed.

> Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:170
> +    void queueTaskToSettleWithResultCallback(TaskSource source,
Function<ExceptionOr<typename IDLType::ParameterType>()>&& resultCallback)

No longer needed.

> Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:177
> +    void queueTaskToSettleWithResultCallback(TaskSource source,
Function<ExceptionOr<void>()>&& resultCallback)

No longer needed.