[webkit-reviews] review granted: [Bug 203989] Entering/Exiting Picture-in-Picture mode through webkitSetPresentationMode() does not fire events (enterpictureinpicture and leavepictureinpicture) defined in the spec : [Attachment 383159] Rebase the patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 203989: Entering/Exiting Picture-in-Picture mode through
webkitSetPresentationMode() does not fire events (enterpictureinpicture and
leavepictureinpicture) defined in the spec
https://bugs.webkit.org/show_bug.cgi?id=203989

Attachment 383159: Rebase the patch

https://bugs.webkit.org/attachment.cgi?id=383159&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 383159
  --> https://bugs.webkit.org/attachment.cgi?id=383159
Rebase the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383159&action=review

> Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h:91
> +void providePictureInPictureTo(HTMLVideoElement&);

I thinks this would be better as a static method on
HTMLVideoElementPictureInPicture than as a free function.