[webkit-reviews] review granted: [Bug 180424] [Win] UIScriptController::zoomToScale not implemented : [Attachment 383026] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 13:39:10 PST 2019

Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 180424: [Win] UIScriptController::zoomToScale not implemented

Attachment 383026: Patch


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383026
  --> https://bugs.webkit.org/attachment.cgi?id=383026

View in context: https://bugs.webkit.org/attachment.cgi?id=383026&action=review

> Tools/DumpRenderTree/win/UIScriptControllerWin.cpp:69
> +    // FIXME: No API to get the page scale factor

I think at this point we probably don't want to fix this.

> Tools/WebKitTestRunner/win/UIScriptControllerWin.cpp:44
> +    callOnMainThread([this, protectedThis = makeRef(*this), callbackID ] {

I don't see why this is necessary.  Can't we just complete the task
immediately?  We're never on a non-main thread, right?

More information about the webkit-reviews mailing list