[webkit-reviews] review granted: [Bug 203784] Add support for finding test references via <link rel="match"> : [Attachment 383132] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 13:26:39 PST 2019

youenn fablet <youennf at gmail.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 203784: Add support for finding test references via <link rel="match">

Attachment 383132: Patch


--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383132
  --> https://bugs.webkit.org/attachment.cgi?id=383132

View in context: https://bugs.webkit.org/attachment.cgi?id=383132&action=review

> Tools/Scripts/webkitpy/port/base.py:550
> +		   _log.warning('Multiple references are not supported.
Importing the first ref defined in {}'.format(test_name))

This code is coming from TestParser whose purpose is to import tests.
The purpose of this code is to run tests, so we should update the message
Or maybe just remove the warning altogether since we know this is a limitation
of webkitpy.

More information about the webkit-reviews mailing list