[webkit-reviews] review granted: [Bug 203872] WKWebView Find-in-page API : [Attachment 383134] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 203872: WKWebView Find-in-page API
https://bugs.webkit.org/show_bug.cgi?id=203872

Attachment 383134: Patch

https://bugs.webkit.org/attachment.cgi?id=383134&action=review




--- Comment #14 from Tim Horton <thorton at apple.com> ---
Comment on attachment 383134
  --> https://bugs.webkit.org/attachment.cgi?id=383134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383134&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKFindResult.mm:33
> +    return [self _initWithMatchFound:NO];

Why's this a thing? Should it be NS_UNAVAILABLE and return nil?

> Source/WebKit/UIProcess/API/Cocoa/WKFindResultInternal.h:29
> + at interface WKFindResult () {
> +}

Why the braces?