[webkit-reviews] review granted: [Bug 204006] Add WebKit Legacy SPI to retrieve editable elements in rect : [Attachment 383142] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 204006: Add WebKit Legacy SPI to retrieve editable elements in rect
https://bugs.webkit.org/show_bug.cgi?id=204006

Attachment 383142: Patch

https://bugs.webkit.org/attachment.cgi?id=383142&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 383142
  --> https://bugs.webkit.org/attachment.cgi?id=383142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383142&action=review

> Source/WebCore/page/Page.cpp:940
> +	       auto node = nodesToSearch.takeFirst();

Nit - auto*

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6696
> +    auto contexts = m_page->editableElementsInRect(searchRect).map([this]
(const auto& element) {

Nit - I think we prefer just auto& over const auto&