[webkit-reviews] review granted: [Bug 203999] [macOS] Add logging and telemetry to mach lookup rules : [Attachment 383127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 11:02:37 PST 2019


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 203999: [macOS] Add logging and telemetry to mach lookup rules
https://bugs.webkit.org/show_bug.cgi?id=203999

Attachment 383127: Patch

https://bugs.webkit.org/attachment.cgi?id=383127&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 383127
  --> https://bugs.webkit.org/attachment.cgi?id=383127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383127&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601
> +)

These look fine, but we seem to be hitting test failures (which seems crazy to
me). Can you double-check we don't have a syntax error in the sandbox?


More information about the webkit-reviews mailing list