[webkit-reviews] review granted: [Bug 204010] [Web Animations] Use a keyframe effect stack to resolve animations on an element : [Attachment 383140] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 204010: [Web Animations] Use a keyframe effect stack to resolve animations
on an element
https://bugs.webkit.org/show_bug.cgi?id=204010

Attachment 383140: Patch

https://bugs.webkit.org/attachment.cgi?id=383140&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 383140
  --> https://bugs.webkit.org/attachment.cgi?id=383140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383140&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:1009
> +    bool animationChanged = animation != this->animation();
> +    AnimationEffect::setAnimation(animation);
> +    if (m_target && animationChanged) {

Would it read better as this?
{
   AnimationEffect::setAnimation(animation);
   if (m_target && animation != this->animation()) {...

I'm not sure.