[webkit-reviews] review granted: [Bug 203962] Make DownloadID an ObjectIdentifier : [Attachment 383072] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 8 06:47:23 PST 2019
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203962: Make DownloadID an ObjectIdentifier
https://bugs.webkit.org/show_bug.cgi?id=203962
Attachment 383072: Patch
https://bugs.webkit.org/attachment.cgi?id=383072&action=review
--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383072
--> https://bugs.webkit.org/attachment.cgi?id=383072
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383072&action=review
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1970
> + downloadProxyConnection()->send(Messages::DownloadProxy::DidCancel({ }),
downloadID.toUInt64());
We can probably remove toUInt64() here and in every send() call site below.
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1975
> + uint64_t destinationID = networkDataTask.pendingDownloadID().toUInt64();
auto destinationID = networkDataTask.pendingDownloadID(); or directly inline
the call where used.
More information about the webkit-reviews
mailing list