[webkit-reviews] review granted: [Bug 203822] Fix flaky tests in http/tests/cache/disk-cache : [Attachment 382803] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 06:43:57 PST 2019

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203822: Fix flaky tests in http/tests/cache/disk-cache

Attachment 382803: Patch


--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 382803
  --> https://bugs.webkit.org/attachment.cgi?id=382803

View in context: https://bugs.webkit.org/attachment.cgi?id=382803&action=review

> Source/WebKit/ChangeLog:8
> +	   Right now tests that set the cache model do so using a race
condition.  I think this will fix the flakyness we've observed.

Is the plan to update TestExpectations at a later stage once the theory is

> Tools/WebKitTestRunner/TestInvocation.cpp:-552
> -	   WKContextSetCacheModel(TestController::singleton().context(),

Should we try to remove WKContextSetCacheModel?

More information about the webkit-reviews mailing list