[webkit-reviews] review granted: [Bug 203822] Fix flaky tests in http/tests/cache/disk-cache : [Attachment 382803] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203822: Fix flaky tests in http/tests/cache/disk-cache
https://bugs.webkit.org/show_bug.cgi?id=203822

Attachment 382803: Patch

https://bugs.webkit.org/attachment.cgi?id=382803&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 382803
  --> https://bugs.webkit.org/attachment.cgi?id=382803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382803&action=review

> Source/WebKit/ChangeLog:8
> +	   Right now tests that set the cache model do so using a race
condition.  I think this will fix the flakyness we've observed.

Is the plan to update TestExpectations at a later stage once the theory is
validated?

> Tools/WebKitTestRunner/TestInvocation.cpp:-552
> -	   WKContextSetCacheModel(TestController::singleton().context(),
model);

Should we try to remove WKContextSetCacheModel?