[webkit-reviews] review granted: [Bug 203795] [JSC] Use LinkTimeConstants and make some properties lazy : [Attachment 383099] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 7 18:20:02 PST 2019

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 203795: [JSC] Use LinkTimeConstants and make some properties lazy

Attachment 383099: Patch


--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 383099
  --> https://bugs.webkit.org/attachment.cgi?id=383099

View in context: https://bugs.webkit.org/attachment.cgi?id=383099&action=review

r=me with comments.

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:2015
> +    if (m_mapIteratorProtocolWatchpointSet.isStillValid()) {

Can't this be an ASSERT? How can this not be valid if you haven't initialized
Map.prototype? I don't think it's possible to access the Map iterator prototype
object without first creating a Map.

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:2030
> +    if (m_setIteratorProtocolWatchpointSet.isStillValid()) {


More information about the webkit-reviews mailing list