[webkit-reviews] review granted: [Bug 203937] [WebAuthn] Return NotAllowedError immediately for UI cancellations : [Attachment 383003] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 7 17:09:05 PST 2019
Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 203937: [WebAuthn] Return NotAllowedError immediately for UI cancellations
https://bugs.webkit.org/show_bug.cgi?id=203937
Attachment 383003: Patch
https://bugs.webkit.org/attachment.cgi?id=383003&action=review
--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 383003
--> https://bugs.webkit.org/attachment.cgi?id=383003
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383003&action=review
r=me, but I would make the patch as small as possible to make it easier to
integrate quickly.
> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:202
> + clearState();
To keep the patch small, I would just keep using resetState here.
> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:-217
> - resetState();
Then you don't need this change.
> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:-357
> -void AuthenticatorManager::resetState()
... or this change.
> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:-95
> - void resetState();
Or this change.
> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:562
> + EXPECT_TRUE(webAuthenticationPanelFailed);
Nice!
More information about the webkit-reviews
mailing list