[webkit-reviews] review granted: [Bug 203958] Many resourceLoadStatistics tests and storageAccess tests using the ITP Database redirect to the corresponding memory store test after setting a cookie : [Attachment 383059] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 203958: Many resourceLoadStatistics tests and storageAccess tests using the
ITP Database redirect to the corresponding memory store test after setting a
cookie
https://bugs.webkit.org/show_bug.cgi?id=203958

Attachment 383059: Patch

https://bugs.webkit.org/attachment.cgi?id=383059&action=review




--- Comment #4 from John Wilander <wilander at apple.com> ---
Comment on attachment 383059
  --> https://bugs.webkit.org/attachment.cgi?id=383059
Patch

Looks good! As discussed, we should come up with a way to make it simple to get
it right, such as generating the redirect URL based on the test case's start
URL or by generating the HTML file's name from a descriptive string such as
"Request and grant access then detach should not have access" ->
"request-and-grant-access-then-detach-should-not-have-access.html".