[webkit-reviews] review granted: [Bug 203960] Port MessagePort to the HTML5 event loop : [Attachment 383055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 7 14:04:22 PST 2019


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203960: Port MessagePort to the HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=203960

Attachment 383055: Patch

https://bugs.webkit.org/attachment.cgi?id=383055&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 383055
  --> https://bugs.webkit.org/attachment.cgi?id=383055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383055&action=review

> Source/WebCore/dom/MessagePort.cpp:278
> -	       m_eventQueue->enqueueEvent(MessageEvent::create(WTFMove(ports),
message.message.releaseNonNull()));
> +	       queueTaskToDispatchEvent(*this, TaskSource::PostedMessage,
MessageEvent::create(WTFMove(ports), message.message.releaseNonNull()));

Hm... the posted message task source is only used for window post message
steps:
https://html.spec.whatwg.org/multipage/web-messaging.html#window-post-message-s
teps
https://html.spec.whatwg.org/multipage/web-messaging.html#posted-message-task-s
ource

Shouldn't this be port message queue or unshipped port message queue?
https://html.spec.whatwg.org/multipage/web-messaging.html#port-message-queue


More information about the webkit-reviews mailing list