[webkit-reviews] review granted: [Bug 203919] Port Worker to the HTML5 event loop : [Attachment 383014] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 7 14:00:17 PST 2019
Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203919: Port Worker to the HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=203919
Attachment 383014: Patch
https://bugs.webkit.org/attachment.cgi?id=383014&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 383014
--> https://bugs.webkit.org/attachment.cgi?id=383014
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=383014&action=review
> Source/WebCore/workers/Worker.cpp:208
> + queueTaskToDispatchEvent(*this, TaskSource::DOMManipulation,
Event::create(eventNames().errorEvent, Event::CanBubble::No,
Event::IsCancelable::Yes));
Shouldn't this be Networking?
> Source/WebCore/workers/WorkerMessagingProxy.cpp:107
> - workerObject->enqueueEvent(MessageEvent::create(WTFMove(ports),
message.message.releaseNonNull()));
> + ActiveDOMObject::queueTaskToDispatchEvent(*workerObject,
TaskSource::DOMManipulation, MessageEvent::create(WTFMove(ports),
message.message.releaseNonNull()));
Shouldn't this be unshipped port message queue?
https://html.spec.whatwg.org/multipage/web-messaging.html#message-port-post-mes
sage-steps
> Source/WebCore/workers/WorkerMessagingProxy.cpp:180
> - workerObject->enqueueEvent(ErrorEvent::create(errorMessage,
sourceURL, lineNumber, columnNumber, { }));
> + ActiveDOMObject::queueTaskToDispatchEvent(*workerObject,
TaskSource::DOMManipulation, ErrorEvent::create(errorMessage, sourceURL,
lineNumber, columnNumber, { }));
Ditto.
More information about the webkit-reviews
mailing list