[webkit-reviews] review granted: [Bug 203963] Port ServiceWorkerContainer to the HTML5 event loop : [Attachment 383058] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203963: Port ServiceWorkerContainer to the HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=203963

Attachment 383058: Patch

https://bugs.webkit.org/attachment.cgi?id=383058&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 383058
  --> https://bugs.webkit.org/attachment.cgi?id=383058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383058&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.h:145
> +    bool m_shouldDeferMessageEvents { false };
> +    Vector<Ref<Event>> m_deferredMessageEvents;

Hm... how does GC keep wrappers for objects held by this event alive?