[webkit-reviews] review granted: [Bug 203839] Integrate scroll event into HTML5 event loop : [Attachment 382982] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 203839: Integrate scroll event into HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=203839

Attachment 382982: Patch

https://bugs.webkit.org/attachment.cgi?id=382982&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 382982
  --> https://bugs.webkit.org/attachment.cgi?id=382982
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382982&action=review

> Source/WebCore/dom/Document.cpp:4018
> +    m_needsVisualViewportScrollEvent = true;
> +    scheduleTimedRenderingUpdate();

Can this avoid calling scheduleTimedRenderingUpdate if
m_needsVisualViewportScrollEvent is already true?

> Source/WebCore/dom/Document.cpp:4041
> +	      
window->visualViewport().dispatchEvent(Event::create(eventNames().scrollEvent,
Event::CanBubble::No, Event::IsCancelable::No));

Is window->visualViewport() always non-null?