[webkit-reviews] review granted: [Bug 203882] WindowEventLoop should be shared among similar origin documents : [Attachment 382985] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 7 12:17:41 PST 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 203882: WindowEventLoop should be shared among similar origin documents
https://bugs.webkit.org/show_bug.cgi?id=203882
Attachment 382985: Patch
https://bugs.webkit.org/attachment.cgi?id=382985&action=review
--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 382985
--> https://bugs.webkit.org/attachment.cgi?id=382985
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=382985&action=review
> Source/WebCore/dom/WindowEventLoop.cpp:58
> + ASSERT(windowEventLoopMap().contains(m_domain));
Do we need both this debug assert and the release assert below?
> LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html:22
> + setTimeout(() => finishJSTest(), 3000);
I don’t think you meant to include this.
More information about the webkit-reviews
mailing list