[webkit-reviews] review granted: [Bug 203121] [bmalloc] Bug fix for wait time when it's in mini mode. : [Attachment 383013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 7 11:11:16 PST 2019


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 203121: [bmalloc] Bug fix for wait time when it's in mini mode.
https://bugs.webkit.org/show_bug.cgi?id=203121

Attachment 383013: Patch

https://bugs.webkit.org/attachment.cgi?id=383013&action=review




--- Comment #17 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 383013
  --> https://bugs.webkit.org/attachment.cgi?id=383013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383013&action=review

r=me

> Source/bmalloc/bmalloc/Scavenger.cpp:-504
> -	   if (m_isInMiniMode) {
> -	       timeSpentScavenging *= 50;
> -	       newWaitTime =
std::chrono::duration_cast<std::chrono::milliseconds>(timeSpentScavenging);
> -	       newWaitTime = std::min(std::max(newWaitTime,
std::chrono::milliseconds(25)), std::chrono::milliseconds(500));
> -	   } else {

Can we file a FIXME?


More information about the webkit-reviews mailing list