[webkit-reviews] review granted: [Bug 203867] JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut() should fire its watchpoint as the last step. : [Attachment 382977] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 203867: JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut()
should fire its watchpoint as the last step.
https://bugs.webkit.org/show_bug.cgi?id=203867

Attachment 382977: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=382977&action=review




--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 382977
  --> https://bugs.webkit.org/attachment.cgi?id=382977
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=382977&action=review

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:1584
> +    // Make sure that all allocations or indexed storage transitions that
are inlining
> +    // the assumption that it's safe to transition to a non-SlowPut array
storage don't
> +    // do so anymore.

maybe also worth a note on the store ordering here?