[webkit-reviews] review granted: [Bug 203366] REGRESSION: [ iOS ] ( r251015 ) Layout Test fast/text/whitespace/pre-wrap-overflow-selection.html is flaky : [Attachment 382941] patch that fixes the underlying flakiness

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 203366: REGRESSION: [ iOS ] ( r251015 ) Layout Test
fast/text/whitespace/pre-wrap-overflow-selection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203366

Attachment 382941: patch that fixes the underlying flakiness

https://bugs.webkit.org/attachment.cgi?id=382941&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 382941
  --> https://bugs.webkit.org/attachment.cgi?id=382941
patch that fixes the underlying flakiness

View in context: https://bugs.webkit.org/attachment.cgi?id=382941&action=review

> Source/WebKit/ChangeLog:13
> +	   In this case the randomess is switch between simple and complex line
layout triggered by editor state flush. The results

"randomess is switch"

> Source/WebKit/ChangeLog:14
> +	   between line layout paths are obsevably identical but produce
slightly different render tree dumps.

"obsevably"

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:518
> +    WebKit::toImpl(page)->flushPendingEditorStateUpdate();

Seems like this is something that we should to at "update the rendering" time?
(In a later fix).