[webkit-reviews] review granted: [Bug 203798] AX: WKWebView does not shift Accessibility Focus for Catalyst : [Attachment 382786] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Eric Liang <ericliang at apple.com>'s
request for review:
Bug 203798: AX: WKWebView does not shift Accessibility Focus for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=203798

Attachment 382786: Patch

https://bugs.webkit.org/attachment.cgi?id=382786&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 382786
  --> https://bugs.webkit.org/attachment.cgi?id=382786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382786&action=review

> Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h:66
> +SOFT_LINK_FRAMEWORK_FOR_HEADER(PAL, AppKit)
> +SOFT_LINK_CLASS_FOR_HEADER(PAL, NSAccessibilityRemoteUIElement)

You moved too much :) These (soft linking bits) should be in -SoftLinking.h/.mm
files like they were. Just the forward declarations needed to move here.

Other than that this looks good.