[webkit-reviews] review granted: [Bug 203876] [Win] WEBCORE_TESTSUPPORT_EXPORT should be used only for WebCoreTestSupport, but for WebCore : [Attachment 382882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 12:18:50 PST 2019


Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 203876: [Win] WEBCORE_TESTSUPPORT_EXPORT should be used only for
WebCoreTestSupport, but for WebCore
https://bugs.webkit.org/show_bug.cgi?id=203876

Attachment 382882: Patch

https://bugs.webkit.org/attachment.cgi?id=382882&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 382882
  --> https://bugs.webkit.org/attachment.cgi?id=382882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382882&action=review

Makes sense and looks like EWS is happy with it.

> Source/WebCore/ChangeLog:3
> +	   [Win] WEBCORE_TESTSUPPORT_EXPORT should be used only for
WebCoreTestSupport, but for WebCore

Nit: "not" for WebCore


More information about the webkit-reviews mailing list