[webkit-reviews] review granted: [Bug 203105] VRDisplay should not prevent entering the back/forward cache : [Attachment 382909] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 08:06:03 PST 2019

Chris Dumez <cdumez at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 203105: VRDisplay should not prevent entering the back/forward cache

Attachment 382909: Patch


--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 382909
  --> https://bugs.webkit.org/attachment.cgi?id=382909

View in context: https://bugs.webkit.org/attachment.cgi?id=382909&action=review

> Source/WebCore/ChangeLog:16
> +	   No new tests were added as there is no testing machinery for WebVR
so far. It's unclear how


> Source/WebCore/Modules/webvr/VRDisplay.cpp:216
> +void VRDisplay::dispatchVRDisplayEventInEventLoop(const WTF::AtomString&
eventName, Optional<VRDisplayEventReason>&& reason)

We likely don't need the WTF::

> Source/WebCore/Modules/webvr/VRDisplay.cpp:261
> +    stopPresenting();

As mentioned earlier, you likely want to stop presenting ONLY if
ReasonForSuspension is ReasonForSuspension::BackForwardCache.

> Source/WebCore/Modules/webvr/VRDisplay.h:119
> +    void dispatchVRDisplayEventInEventLoop(const WTF::AtomString& eventName,

WTF:: likely unnecessary.

More information about the webkit-reviews mailing list