[webkit-reviews] review denied: [Bug 203867] JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut() should fire its watchpoint as the last step. : [Attachment 382905] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 203867: JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut()
should fire its watchpoint as the last step.
https://bugs.webkit.org/show_bug.cgi?id=203867

Attachment 382905: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=382905&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 382905
  --> https://bugs.webkit.org/attachment.cgi?id=382905
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=382905&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7987
> +	   sleep(Seconds::fromMicroseconds(100));

This is crazy. We can’t have code in the compiler like this loop. We should
restructure the code to not have this problem.