[webkit-reviews] review requested: [Bug 203867] JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut() should fire its watchpoint as the last step. : [Attachment 382905] proposed patch.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 203867: JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut()
should fire its watchpoint as the last step.
https://bugs.webkit.org/show_bug.cgi?id=203867

Attachment 382905: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=382905&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Created attachment 382905

  --> https://bugs.webkit.org/attachment.cgi?id=382905&action=review

proposed patch.

I added more code to placate a DFG_ASSERT in SpeculativeJIT::compileNewArray().
 We could just remove that assert, but I felt that there's some value in
keeping it.  So, let's get another review to see if anyone is strongly opposed
to this change.