[webkit-reviews] review denied: [Bug 201461] Support stale-while-revalidate cache strategy : [Attachment 381827] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 201461: Support stale-while-revalidate cache strategy
https://bugs.webkit.org/show_bug.cgi?id=201461

Attachment 381827: Patch

https://bugs.webkit.org/attachment.cgi?id=381827&action=review




--- Comment #23 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 381827
  --> https://bugs.webkit.org/attachment.cgi?id=381827
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381827&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:142
> +WK_EXPORT void WKContextSetStaleWhileRevalidateEnabled(WKContextRef, bool
enabled);

We should not be increasing the call sites where WKContextRef means global in
the NetworkProcess.  I think we should instead have this boolean
per-WebsiteDataStore.
Also, what if it instead is an off-by-default setting that is always on in
WebKitTestRunner?  That way we wouldn't have to modify the WebPlatformTests. 
Since there's nothing else that uses the header, there should be no problems
created by other tests.