[webkit-reviews] review denied: [Bug 201461] Support stale-while-revalidate cache strategy : [Attachment 381827] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 5 05:57:13 PST 2019

Alex Christensen <achristensen at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 201461: Support stale-while-revalidate cache strategy

Attachment 381827: Patch


--- Comment #23 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 381827
  --> https://bugs.webkit.org/attachment.cgi?id=381827

View in context: https://bugs.webkit.org/attachment.cgi?id=381827&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:142
> +WK_EXPORT void WKContextSetStaleWhileRevalidateEnabled(WKContextRef, bool

We should not be increasing the call sites where WKContextRef means global in
the NetworkProcess.  I think we should instead have this boolean
Also, what if it instead is an off-by-default setting that is always on in
WebKitTestRunner?  That way we wouldn't have to modify the WebPlatformTests. 
Since there's nothing else that uses the header, there should be no problems
created by other tests.

More information about the webkit-reviews mailing list