[webkit-reviews] review canceled: [Bug 203663] [Win][CMake] Build WebCore as an OBJECT library unless Apple internal builds : [Attachment 382562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 19:46:21 PST 2019


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 203663: [Win][CMake] Build WebCore as an OBJECT library unless Apple
internal builds
https://bugs.webkit.org/show_bug.cgi?id=203663

Attachment 382562: Patch

https://bugs.webkit.org/attachment.cgi?id=382562&action=review




--- Comment #12 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 382562
  --> https://bugs.webkit.org/attachment.cgi?id=382562
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382562&action=review

>> Source/WebCore/CMakeLists.txt:1237
>> +endif ()
> 
> Is this part not needed for Apple-internal Windows builds?

Nope. Apple internal builds invokes CMake under each sub-directory. This is
irrelevant for it.


More information about the webkit-reviews mailing list