[webkit-reviews] review granted: [Bug 203830] [WebAuthn] Guard towards unexpected -[_WKWebAuthenticationPanel cancel] : [Attachment 382785] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 203830: [WebAuthn] Guard towards unexpected -[_WKWebAuthenticationPanel
cancel]
https://bugs.webkit.org/show_bug.cgi?id=203830

Attachment 382785: Patch

https://bugs.webkit.org/attachment.cgi?id=382785&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 382785
  --> https://bugs.webkit.org/attachment.cgi?id=382785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382785&action=review

R=me

> Source/WebKit/ChangeLog:3
> +	   [WebAuthn] Guard towards unexpected -[_WKWebAuthenticationPanel
cancel]

Guard against

> Source/WebKit/ChangeLog:9
> +	   -[_WKWebAuthenticationPanel cancel] was only expected to be called
on behave of an

On behalf of

> Source/WebKit/ChangeLog:11
> +	   unexpected scenarios as well. We should guard ourselves towards
that.

We should guard against that.

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:182
> +    if (m_pendingRequestData.frameID) {

If (auto* pendingFrameID = m_pendingRequestData.frameID)

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
:62
> +    // Call delegates in the next run loop to prevent clients' reentrance
that would potentially modify the states

State should be singular in this use.

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
:63
> +    // of current run loop in unexpected ways.

Of the current

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
:94
> +    // of current run loop in unexpected ways.

Ditto for both prior comments.