[webkit-reviews] review granted: [Bug 203817] Add Googletest assertion support for CGRect and NSRect : [Attachment 382752] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 203817: Add Googletest assertion support for CGRect and NSRect
https://bugs.webkit.org/show_bug.cgi?id=203817

Attachment 382752: Patch

https://bugs.webkit.org/attachment.cgi?id=382752&action=review




--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 382752
  --> https://bugs.webkit.org/attachment.cgi?id=382752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382752&action=review

> Tools/TestWebKitAPI/cocoa/TestCocoa.mm:32
> +    return os << "(origin = (x = " << rect.origin.x << ", y = " <<
rect.origin.y << "), size = (width = " << rect.size.width << ", height = " <<
rect.size.height << "))";

makeString() would make this more elegant