[webkit-reviews] review granted: [Bug 202218] Web Inspector: "Toggle Visibility" does not work for element inside Shadow DOM : [Attachment 382750] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 15:15:13 PST 2019


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 202218: Web Inspector: "Toggle Visibility" does not work for element inside
Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=202218

Attachment 382750: Patch

https://bugs.webkit.org/attachment.cgi?id=382750&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 382750
  --> https://bugs.webkit.org/attachment.cgi?id=382750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382750&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:354
> +		   else

Please add '// Inside Shadow DOM.'  to the else branch.


More information about the webkit-reviews mailing list