[webkit-reviews] review denied: [Bug 203431] REGRESSION (r250754): web page using IDBIndex doesn't load occasionally : [Attachment 382659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 12:55:14 PST 2019

Brady Eidson <beidson at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203431: REGRESSION (r250754): web page using IDBIndex doesn't load

Attachment 382659: Patch


--- Comment #12 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 382659
  --> https://bugs.webkit.org/attachment.cgi?id=382659

View in context: https://bugs.webkit.org/attachment.cgi?id=382659&action=review

> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:470
> +    if (scriptExecutionContext()->isDocument()) {

If the global object that has the open database handle is a web worker (i.e.
not a Document) then it will not do the right thing here.

IDB is frequently used by workers, so we definitely have to handle that case.

I wonder if Workers know if their owning document is in the page cache?
If not, I wonder how hard it would be to teach them?

Regardless, we need to solve that.

> Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h:88
> +    void didFireVersionChangeEvent(uint64_t databaseConnectionIdentifier,
const IDBResourceIdentifier& requestIdentifier, bool

Hard to read with trues and falses scattered about.
Let's make the bool be an enum.

More information about the webkit-reviews mailing list