[webkit-reviews] review granted: [Bug 203652] Flaky API Test TestWebKitAPI.WebKit.UploadDirectory : [Attachment 382741] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 09:06:19 PST 2019

Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203652: Flaky API Test TestWebKitAPI.WebKit.UploadDirectory

Attachment 382741: Patch


--- Comment #12 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 382741
  --> https://bugs.webkit.org/attachment.cgi?id=382741

I would slightly prefer checking for the error or asserting after deleting.
Knowing that deletion succeeded will make it easier to reason about future
failures, if any occur.

r=me with or without such changes.

More information about the webkit-reviews mailing list