[webkit-reviews] review granted: [Bug 203809] REGRESSION(r243947) Epson software updater fails to install new version : [Attachment 382742] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 09:01:31 PST 2019


Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203809: REGRESSION(r243947) Epson software updater fails to install new
version
https://bugs.webkit.org/show_bug.cgi?id=203809

Attachment 382742: Patch

https://bugs.webkit.org/attachment.cgi?id=382742&action=review




--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 382742
  --> https://bugs.webkit.org/attachment.cgi?id=382742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382742&action=review

> Source/WebKitLegacy/mac/Misc/WebDownload.mm:122
> +    if (isDelegateThread())

Is there any reason we even have "isDelegateThread"?

Couldn't we just always use "callOnDelegateThread"?

Even the forms of this that need a sync return value should be able to work
with that, right?


More information about the webkit-reviews mailing list