[webkit-reviews] review granted: [Bug 203633] [iOS][WK2] Simplify process assertion handling for the network process and service worker processes : [Attachment 382375] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 203633: [iOS][WK2] Simplify process assertion handling for the network
process and service worker processes
https://bugs.webkit.org/show_bug.cgi?id=203633

Attachment 382375: Patch

https://bugs.webkit.org/attachment.cgi?id=382375&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 382375
  --> https://bugs.webkit.org/attachment.cgi?id=382375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382375&action=review

> Source/WebKit/UIProcess/ProcessThrottler.h:95
> +    using ActivityVariant = Variant<std::nullptr_t,
std::unique_ptr<BackgroundActivity>, std::unique_ptr<ForegroundActivity>>;

Could you use UniqueRef here?  You use the non-std::nullptr_t types as if they
are always non-null, and right now the nullptr constructor is quite ambiguous. 
I guess you only use the default constructor, but still...