[webkit-reviews] review granted: [Bug 203407] enumerateDevices() doesn't return correct list of devices after device was changed by user in a system preferences : [Attachment 382738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 07:58:49 PST 2019


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 203407: enumerateDevices() doesn't return correct list of devices after
device was changed by user in a system preferences
https://bugs.webkit.org/show_bug.cgi?id=203407

Attachment 382738: Patch

https://bugs.webkit.org/attachment.cgi?id=382738&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 382738
  --> https://bugs.webkit.org/attachment.cgi?id=382738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382738&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:131
> +		   callOnMainThread([] {

We probably do not need callOnMainThread since we ask the listener to be called
on dispatch_get_main_queue.


More information about the webkit-reviews mailing list