[webkit-reviews] review granted: [Bug 203779] [LFC][Verification] Forced line break display runs don't have TextContext : [Attachment 382676] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 203779: [LFC][Verification] Forced line break display runs don't have
TextContext
https://bugs.webkit.org/show_bug.cgi?id=203779

Attachment 382676: Patch

https://bugs.webkit.org/attachment.cgi?id=382676&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 382676
  --> https://bugs.webkit.org/attachment.cgi?id=382676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382676&action=review

> Source/WebCore/layout/Verification.cpp:127
>	   && areEssentiallyEqual(inlineTextBox.logicalRight(),
inlineRun.logicalRight())
>	   && areEssentiallyEqual(inlineTextBox.logicalTop(),
inlineRun.logicalTop())
>	   && areEssentiallyEqual(inlineTextBox.logicalBottom(),
inlineRun.logicalBottom())

There is areEssentiallyEqual for LayoutRects that could be used here.