[webkit-reviews] review granted: [Bug 203787] LLIntGenerator should not allocate temporaries in between variables : [Attachment 382684] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 2 22:58:51 PDT 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 203787: LLIntGenerator should not allocate temporaries in between variables
https://bugs.webkit.org/show_bug.cgi?id=203787

Attachment 382684: Patch

https://bugs.webkit.org/attachment.cgi?id=382684&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 382684
  --> https://bugs.webkit.org/attachment.cgi?id=382684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382684&action=review

r=me

> Source/JavaScriptCore/wasm/WasmValidate.cpp:178
> +    void finishedParsingLocals() { }

In WebCore, this type of callback is named as didFinishParsingLocals. Can you
align it to this?


More information about the webkit-reviews mailing list