[webkit-reviews] review granted: [Bug 203772] Port DOMCache / DOMCacheStorage to the HTML5 event loop : [Attachment 382683] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 2 19:43:39 PDT 2019

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203772: Port DOMCache / DOMCacheStorage to the HTML5 event loop

Attachment 382683: Patch


--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 382683
  --> https://bugs.webkit.org/attachment.cgi?id=382683

View in context: https://bugs.webkit.org/attachment.cgi?id=382683&action=review

> Source/WebCore/workers/WorkerEventLoop.cpp:101
> +    auto tasks = WTFMove(m_tasks);

I think the kosher way of doing this is to swap with an empty Vector<Task>.
Otherwise, it leaves m_tasks in a bad (though currently kind of ok) state.

More information about the webkit-reviews mailing list