[webkit-reviews] review granted: [Bug 203579] Web Inspector: Add diagnostic logging for frontend feature usage : [Attachment 382663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 23:06:27 PDT 2019

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 203579: Web Inspector: Add diagnostic logging for frontend feature usage

Attachment 382663: Patch


--- Comment #13 from Brian Burg <bburg at apple.com> ---
Comment on attachment 382663
  --> https://bugs.webkit.org/attachment.cgi?id=382663

View in context: https://bugs.webkit.org/attachment.cgi?id=382663&action=review


> Source/WebKit/ChangeLog:9
> +	   This patch enable diagnostic logging for the Web Inspector web

Nit: enables

> Source/WebInspectorUI/UserInterface/Controllers/DiagnosticController.js:92
> +	   this._tabActivityTimeoutidentifier = setTimeout(() => {

Nit: this._tabActivityTimeoutIdentifier

> Source/WebKit/UIProcess/mac/WKInspectorViewController.mm:123
> +    preferences._diagnosticLoggingEnabled = YES;

Are you aware of any existing diagnostic logging that would be bad to enable
for normal Web Inspector usage?

More information about the webkit-reviews mailing list