[webkit-reviews] review granted: [Bug 203771] [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish requestData().options : [Attachment 382657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 17:28:00 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 203771: [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish
requestData().options
https://bugs.webkit.org/show_bug.cgi?id=203771

Attachment 382657: Patch

https://bugs.webkit.org/attachment.cgi?id=382657&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 382657
  --> https://bugs.webkit.org/attachment.cgi?id=382657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review

> Source/WebKit/ChangeLog:14
> +	   No tests given there is no way to spoof google.com in our test
infrastructures.

It might be better to say, "... no way to simulate google.com in our test
infrastructure."


More information about the webkit-reviews mailing list