[webkit-reviews] review granted: [Bug 203765] REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate : [Attachment 382635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 15:05:37 PDT 2019


Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 203765: REGRESSION(r248696): Element Click on Mac is adding an extra page
topContentInsets to y-coordinate
https://bugs.webkit.org/show_bug.cgi?id=203765

Attachment 382635: Patch

https://bugs.webkit.org/attachment.cgi?id=382635&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 382635
  --> https://bugs.webkit.org/attachment.cgi?id=382635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382635&action=review

r=me, an all negative diff I love it =D

> Source/WebKit/ChangeLog:11
> +	   The topContentInsets is now accounted for by rootViewToWindow(), so
don't add it in manually.

Shouldn't this just be "The topContentInset is"?

Also, was this something that changed recently (the "now" makes it seem like
this wasn't the case before)?  If so, do you know what revision?  If not,
please remove the "now".


More information about the webkit-reviews mailing list