[webkit-reviews] review canceled: [Bug 203719] Web Inspector: Sources: tab isn't visible after removal of Debugger Tab and Resources Tab : [Attachment 382545] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 1 13:54:25 PDT 2019
Devin Rousso <drousso at apple.com> has canceled review:
Bug 203719: Web Inspector: Sources: tab isn't visible after removal of Debugger
Tab and Resources Tab
https://bugs.webkit.org/show_bug.cgi?id=203719
Attachment 382545: Patch
https://bugs.webkit.org/attachment.cgi?id=382545&action=review
--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 382545
--> https://bugs.webkit.org/attachment.cgi?id=382545
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=382545&action=review
>> Source/WebInspectorUI/UserInterface/Base/Main.js:154
>> + // Replace the Debugger/Resources Tab with the Sources Tab.
>
> Please extract this into a separate function. Maybe even a separate file like
MigrationUtilities.js. When we decide this code is no longer worth the trouble
(say, Catalina + 1, or based on telemetry showing its use has diminished) then
we can easily remove it.
This already landed in r251922
>> Source/WebInspectorUI/UserInterface/Base/Main.js:155
>> + let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger");
>
> It seems weird we have a symbolic name for "debugger" or "resources" tab?
This was the value of `WI.DebuggerTabContentView.Type` and
`WI.ResourcesTabContentView.Type`. It's the identifier we used for
saving/restoring.
More information about the webkit-reviews
mailing list