[webkit-reviews] review granted: [Bug 203744] Web Inspector: switching tabs should re-focus the previously focused element : [Attachment 382591] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 12:04:52 PDT 2019


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 203744: Web Inspector: switching tabs should re-focus the previously
focused element
https://bugs.webkit.org/show_bug.cgi?id=203744

Attachment 382591: Patch

https://bugs.webkit.org/attachment.cgi?id=382591&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 382591
  --> https://bugs.webkit.org/attachment.cgi?id=382591
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317
> +	   if (treeElement)

We still want selectedByUser = false, otherwise this will cause an extra
history entry in the back/forward for the content area.


More information about the webkit-reviews mailing list