[webkit-reviews] review granted: [Bug 203743] Web Inspector: default to focusing the console prompt if no other content is focused after opening Web Inspector : [Attachment 382590] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 203743: Web Inspector: default to focusing the console prompt if no other
content is focused after opening Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=203743

Attachment 382590: Patch

https://bugs.webkit.org/attachment.cgi?id=382590&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 382590
  --> https://bugs.webkit.org/attachment.cgi?id=382590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review

Thank you!

> Source/WebInspectorUI/UserInterface/Base/Main.js:925
> +    return !WI._defaultFocusedQuickConcolePrompt &&
WI.quickConsole.prompt.focused;

Nit: s/_defaultFocusedQuickConcolePrompt/_defaultFocusedQuickConsolePrompt/

> Source/WebInspectorUI/UserInterface/Base/Main.js:1364
> +    WI._defaultFocusedQuickConcolePrompt = false;

Ditto.

> Source/WebInspectorUI/UserInterface/Base/Main.js:1546
> +	   WI._defaultFocusedQuickConcolePrompt = true;

Ditto